Update newHistogram of testmetrics Provider #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Sure Thanks! @ypaq |
slizco
approved these changes
May 7, 2024
This reverts commit 8133b8f.
ypaq
approved these changes
May 7, 2024
Vamsi-Mundra
changed the title
voidlock
approved these changes
May 8, 2024
Add CardinalityCounter to testmertics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason For the Change:
While using testmetrics provider in the testcases, we observed CheckObservation is failing when we don't add anything inside the Histogram.
When we are sending an empty float64 list:
empty := float64[]to CheckObservation, it was failing .The reason is, we are not initializing observations in the newHistogram function of the testmetrics provider.
Changes:
Initializing the observations of Histogram in newHistogram function.