Add CardinalityCounter to testmertics #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons For the Change:
While we are using testmetrics pkg in one of our unit tests, we observed
CheckCardinalityCounter
is not working as expected.Inside the
Provider
of testmetrics, all the counters we are using, are ofmetrics.go
except forcardCounters
. ForcardCounters
we are usingxmetrics.HLLCounter
. We weren't adding labels properly andCheckCardinalityCounter
was not takinglabelValues
. Also all the counters ofmetrics.go
are havingProvider
of testmetrics which is not forxmetrics.HLLCounter
. We wanted to add newCardinalityCounter
insidemetrics.go
of testmetrics that hasProvider
inside it and adds, checks for labels correctly.Changes: