Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M114-LTS][codegen] Install BytecodeArray last in SharedFunctionInfo
M114 merge issues: codegen/compiler.cc: set_age() isn't called in 114 - removed it from the change. Maglev assumes that when a SharedFunctionInfo has a BytecodeArray, then it should also have FeedbackMetadata. However, this may not hold with concurrent compilation when the SharedFunctionInfo is re-compiled after being flushed. Here the BytecodeArray was installed on the SFI before the FeedbackMetadata and a concurrent thread could observe the BytecodeArray but not the FeedbackMetadata. Drive-by: Reset the age field before setting the BytecodeArray as well. This ensures that the concurrent marker will not observe the old age for the new BytecodeArray. (cherry picked from commit 46cb67e) Bug: chromium:1507412 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I8855ed7ecc50c4a47d2c89043d62ac053858bc75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5125960 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#91568} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5189926 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/11.4@{v8#79} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
- Loading branch information