Check if header has already been set #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
previously requested changes
Jun 4, 2018
lib/middlewares/route.js
Outdated
| @@ -30,7 +30,10 @@ module.exports = function(app) { | |||
| return; | |||
| } | |||
|
|
|||
| res.setHeader('Content-Type', extname ? mime.lookup(extname) : 'application/octet-stream'); | |||
| // Do not overwrite header if already set by another middleware | |||
| if (!res.getHeader('Content-Type')) { | |||
There was a problem hiding this comment.
Please use hasHeader to detect whether a header has been set and add test for the new behaviors. Otherwise it looks good to me.
There was a problem hiding this comment.
Done, though hasHeader will not work with Node < 7.7.0
9662
force-pushed
the
48-prevent-content-type-overwrite
branch
from
c800616
to
952becc
Compare
9662
force-pushed
the
48-prevent-content-type-overwrite
branch
from
952becc
to
38a6831
Compare
stevenjoezhang
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.