Generate draft assets in draft mode #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing jobs do not seem to be related to my changes |
|
Can you merge the latest master? It fix some Action issues |
darekkay
force-pushed
the
missing-assets
branch
from
839c7e8
to
b286dbd
Compare
|
I've rebased my branch onto the latest master. But now I can't see any GitHub actions being executed anymore. |
jiangtj
requested changes
Mar 15, 2021
I also don't understand why 😂 |
darekkay
force-pushed
the
missing-assets
branch
from
b286dbd
to
07b3344
Compare
darekkay
force-pushed
the
missing-assets
branch
2 times, most recently
from
1c77a68
to
006abfa
Compare
|
I'm happy if someone wants to take over the 0.05% drop in test coverage. |
Since hexojs#3489, no draft assets are generated. This is the desired behavior when not rendering draft posts. But when working on drafts, the according assets are never rendered. This change checks if draft posts should be rendered, and if this is the case, the assets will not be deleted. I validated this fix by - Running `hexo clean && rm -rf public/ && hexo generate` - Draft assets are not generated (as before) - Running `hexo clean && rm -rf public/ && hexo generate --draft` - Draft assets are generated - Running `hexo server --draft` - Draft assets are generated - Adjusting the existing unit test Fixes: hexojs#4556
darekkay
force-pushed
the
missing-assets
branch
from
006abfa
to
27c098e
Compare
jiangtj
approved these changes
Mar 17, 2021
|
I am surprised this fix is not included in 5.4.0. Can anyone please add this fix to the new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Since #3489, no draft assets are generated. This is the desired behavior when not rendering draft posts. But when working on drafts, the according assets are never rendered. This change checks if draft posts should be rendered, and if this is the case, the assets will not be deleted.
How to test
I validated this fix by
hexo clean && rm -rf public/ && hexo generate- Draft assets are not generated (as before)hexo clean && rm -rf public/ && hexo generate --draft- Draft assets are generatedhexo server --draft- Draft assets are generatedFixes: #4556
Pull request tasks