Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix js-yaml tags for v4.0.0+ (#4869) #4876

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Fix js-yaml tags for v4.0.0+ (#4869) #4876

merged 1 commit into from
Jan 22, 2022

Conversation

yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Jan 22, 2022 •
edited

What does it do?

This PR for apply #4869 to 5.4.x.
I will release 5.4.1 after merge this PR.

This PR target branch is 5.4.x not a master.

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@marcofranssen @yoshinorin
Fix js-yaml tags for v4.0.0+ (hexojs#4869)
0251a13 
Repair backwards compatibility https://github.com/nodeca/js-yaml/blob/master/migrate_v3_to_v4.md
with a bunch of plugins that use these yaml tags.

e.g.: https://github.com/lavas-project/hexo-pwa#options uses these yaml tags in the routes `!!js/regexp`
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 98.308% when pulling 0251a13 on yoshinorin:fix/js-yaml into b65a562 on hexojs:5.4.x.

This was referenced Jan 22, 2022
Merged
Merged
@yoshinorin yoshinorin merged commit 81d0b24 into hexojs:5.4.x Jan 22, 2022
@yoshinorin yoshinorin deleted the fix/js-yaml branch January 22, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoshinorin @coveralls @SukkaW @marcofranssen