Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop vimeo tag #5065

Merged
merged 1 commit into from Sep 18, 2022
Merged

refactor: drop vimeo tag #5065

merged 1 commit into from Sep 18, 2022

Conversation

yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Sep 17, 2022 •
edited

What does it do?

Same with #5064 reason

Screenshots

N/A

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b refactor/drop-vimeo-tag https://github.com/yoshinorin/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 98.334% when pulling 494ac03 on yoshinorin:refactor/drop-vimeo-tag into 4d42d9d on hexojs:master.

@renbaoshuo renbaoshuo merged commit 976c897 into hexojs:master Sep 18, 2022
@renbaoshuo renbaoshuo added this to the 7.0.0 milestone Sep 18, 2022
@yoshinorin yoshinorin deleted the refactor/drop-vimeo-tag branch September 18, 2022 06:11
@stevenjoezhang
Copy link
Member

See also #3283

@stevenjoezhang stevenjoezhang mentioned this pull request Nov 24, 2022
Closed
2 tasks
@yoshinorin
Copy link
Member Author

refs: #5113 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renbaoshuo renbaoshuo renbaoshuo approved these changes

Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoshinorin @coveralls @stevenjoezhang @renbaoshuo