sysaudio: fix wasapi format selection + fix crash without capture device #1206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in the
play-opus
example on my Windows 11 machine, wherein no audio format is selected and crashes when trying to read fromdevice.formats[0]
.(Stacktrace for reference: https://gist.github.com/Andoryuuta/defa7bef64bfd5d14e913e5dd9b04284)
Additionally, while debugging this, I found that the example would also crash on startup when my microphone was not plugged in. Small drive-by fix for that is included in this MR as well.
This "works on my machine", but I'm not confident I understand the intentions of the previous code enough to say that this is completely correct.