Skip to content

Commit

Permalink
fix(github): ci workflow should not fail because coveralls is having …
Browse files Browse the repository at this point in the history
…a bad day
  • Loading branch information
hfreire committed May 11, 2021
1 parent 54ee5a3 commit 3835d94
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 111 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- name: Set VERSION env var
run: echo ::set-env name=VERSION::${GITHUB_REF##*/}
run: echo "VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
- uses: actions/checkout@v1
with:
ref: ${{ github.ref }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
- name: Test docker image
run: npm run docker:test
- name: Submit coveralls test coverage report
run: npm run coveralls
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
uses: coverallsapp/github-action@v1.1.2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: Check if release should be created
run: npm run semantic-release
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
104 changes: 0 additions & 104 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"babel-eslint": "10.1.0",
"chai": "4.3.3",
"chai-as-promised": "7.1.1",
"coveralls": "3.1.0",
"eslint": "7.21.0",
"eslint-config-hfreire": "2.0.7",
"eslint-plugin-import": "2.22.1",
Expand Down Expand Up @@ -68,7 +67,6 @@
"docker:build": "DOCKER_REPO=hfreire NAME=$npm_package_name ./share/docker/scripts/build",
"docker:push": "DOCKER_REPO=hfreire NAME=$npm_package_name ./share/docker/scripts/push",
"docker:test": "DOCKER_REPO=hfreire NAME=$npm_package_name ./share/docker/scripts/test",
"coveralls": "cat ./coverage/lcov.info | ./node_modules/.bin/coveralls",
"semantic-release": "./node_modules/.bin/semantic-release",
"clean": "rm -rf coverage",
"lint": "npm run eslint",
Expand Down

0 comments on commit 3835d94

Please sign in to comment.