Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Top level code in examples #30

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lexidor
Copy link
Contributor

@lexidor lexidor commented May 25, 2023

fixes #26

Fixes:

  • Lint errors (classes which are not final, nor abstract).
  • Removes HH_IGNORE_ERROR/HH_FIXME directives.
  • Create an <<__Explicit>> version of EnumRequestParameter to prevent hh_client from rebinding the generic.
  • Make the examples runnable without top-level code.

The type inference engine rebinds the T when it pleases.
The <<__Explicit>> annotation should prevent this programming mistake.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples do not work on hhvm 4.111: Found top-level code in BaseRouterExample.php
2 participants