Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

工单部分接口调用合并至api #1897

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

工单部分接口调用合并至api #1897

wants to merge 11 commits into from

Conversation

hhyo
Copy link
Owner

@hhyo hhyo commented Oct 7, 2022

  • 升级部分基础依赖(未完全测试)
  • 调整api项目的目录结构
  • 部分工单接口转移至api,版本为v2

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Attention: 137 lines in your changes are missing coverage. Please review.

Comparison is base (90fc156) 76.34% compared to head (519e357) 76.05%.

Files Patch % Lines
sql_api/serializers/sql_workflow.py 54.48% 71 Missing ⚠️
sql_api/api_views/sql_workflow.py 60.57% 41 Missing ⚠️
sql_api/permissions/sql_workflow.py 43.90% 23 Missing ⚠️
sql_api/serializers/__init__.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1897      +/-   ##
==========================================
- Coverage   76.34%   76.05%   -0.30%     
==========================================
  Files         115      119       +4     
  Lines       15852    15862      +10     
==========================================
- Hits        12103    12064      -39     
- Misses       3749     3798      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hhyo hhyo force-pushed the sql-wofkflow-api branch 2 times, most recently from e7d2cec to cf186c6 Compare October 22, 2022 15:00
@hhyo hhyo force-pushed the sql-wofkflow-api branch 2 times, most recently from b69ccc8 to a107ec6 Compare March 31, 2023 16:35
@hhyo hhyo force-pushed the sql-wofkflow-api branch 2 times, most recently from 3ce6ab8 to 6f6a816 Compare November 25, 2023 09:37
@@ -27,7 +27,7 @@
)
from sql.utils.resource_group import auth_group_users
from sql.utils.workflow_audit import Audit
from sql_api.serializers import (
from sql_api.serializers.serializers import (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在 serializers/__init__.py 里面 from .sql_workflow import xxxx

这样之前 import 的不用改, 这个路径也不会显得很奇怪, 你觉得如何

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants