Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

资源组中增加上线checklist属性 #2103

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

allen12921
Copy link
Contributor

1.在资源组中添加上线checklist,以便在用户提交上线sql时作出必要的上线提示。
需要执行下面的sql语句
alter table resource_group ADD COLUMN group_checklist longtext DEFAULT '' AFTER qywx_webhook;

2.当SQL上线检查存在warning或者error时,不允许提交SQL。

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a42d5c) 76.21% compared to head (c3ab0e6) 76.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files         113      113           
  Lines       15801    15802    +1     
=======================================
+ Hits        12042    12043    +1     
  Misses       3759     3759           
Files Coverage Δ
sql/admin.py 92.85% <ø> (ø)
sql/models.py 96.93% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hhyo
Copy link
Owner

hhyo commented Mar 31, 2023

感谢贡献,这个可以提供一个具体的使用case和截图吗

@allen12921
Copy link
Contributor Author

例如:

  1. 我们的一个环境对应多个数据库,上线时需要运行重复的sql到多个环境,未免遗漏,因此我们可以添加上checklist信息作为提醒。
  2. sql上线后还需要做一些额外的检查,以确保服务运行正常。
  3. 其它任何需要在SQL上线时提醒的信息。

针对这些资源组我们可以配置额外的上线checklist,以便在“SQL提交”时以弹窗的形式提示用户,如果资源组的checklist为空,则不出现此弹窗。
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants