Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-server): consistent history pathname encoding + support Link.activeProps #276

Merged
merged 10 commits into from Apr 8, 2024

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Apr 8, 2024

I'm not sure whether the fix belongs to @tanstack/history itself. For now, we can just wrap history.push/replace to always keep encoded version as a history location.

todo

  • implement tanstack router-like activeProps
    • NavLink's match logic also needs to be done against encoded version instead of propt.href string directly.
  • test
  • check if tanstack issues and fix there

@hi-ogawa hi-ogawa marked this pull request as ready for review April 8, 2024 05:14
@hi-ogawa hi-ogawa changed the title fix(react-server): consistent history pathname encoding fix(react-server): consistent history pathname encoding + support Link.activeProps Apr 8, 2024
@hi-ogawa hi-ogawa changed the title fix(react-server): consistent history pathname encoding + support Link.activeProps fix(react-server): consistent history pathname encoding + feat: support Link.activeProps Apr 8, 2024
@hi-ogawa hi-ogawa changed the title fix(react-server): consistent history pathname encoding + feat: support Link.activeProps fix(react-server): consistent history pathname encoding + support Link.activeProps Apr 8, 2024
@hi-ogawa hi-ogawa merged commit 039e814 into main Apr 8, 2024
4 checks passed
@hi-ogawa hi-ogawa deleted the fix-state-pathname-encoding branch April 8, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent NavLink matching
1 participant