-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-18132 Add support for skip locked for HANA #8396
Conversation
d49807d
to
79e88ee
Compare
Corrected the issue with the string returned by getSkipLocked not containing the heading space and added an implementation for getForUpdateSkipLockedString in AbstractHANADialect. |
Hello there, |
I fixed the issue with the version detection (which was caused by a misunderstanding of mine in how HANA version numbering works). My own tests had a positive result, so I'm putting this in ready for review. |
Will take a look at the failing tests as soon as I get home from work |
Don't worry about these test failures, those are different errors. Your PR is fine. Thanks. |
Thank you so much! It's actually my first time I submit a pull request for an open source project so I'm very glad this went smoothly. Thanks again. |
Thanks for your contribution. Looking forward to your next one ;) |
https://hibernate.atlassian.net/browse/HHH-18132