-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HSEARCH-4971 Switch project license to Apache License 2.0 #4062
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
01d5a4f
to
dae0b80
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's approved. Congratulations!
Quality Gate passedIssues Measures |
https://hibernate.atlassian.net/browse/HSEARCH-4971
See https://in.relation.to/2023/11/18/license/
Creating as draft while we're reviewing some final details.=> All good!Best reviewed commit by commit, due to the huge, annoying commit that changes file headers (which, obviously, doesn't need reviewing -- there are automated checks for that).
I've gone through past contributions and, unless I am mistaken, we've got permission for this change from all authors of non-trivial contributions that are still present in the repo (some contributions have been deleted in subsequent refactorings, mainly Hibernate Search 6.0).
I've also had to remove a few tests inherited from Search 5, which nowadays are mainly relevant to the v5migrationhelper modules, so... they would probably have been removed in 8.0 along with the v5 migration helpers anyway. Not to detract from those contributions, they were definitely useful (and will continue to be) in v5; it's just that a lot has changed since then, so in newer versions, we can live without them.