Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HV-1970 Add Korean specific RRN annotation #1338

Closed
wants to merge 20 commits into from

Conversation

ing9990
Copy link

@ing9990 ing9990 commented Jan 12, 2024

Jira-(HV-1970)

Hai I tried to add Korean specific @rrn annotation.
I added annotation, validator, testcases, messages, etc.

Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.

This post on adding new constraints may be interesting to you, if you haven't seen it before: https://in.relation.to/2018/01/04/adding-new-constraint-to-engine/ . See the annotation processor and documentation steps in particular.
Also, maybe you could update the ValidationMessages_ko.properties file with the new message as well?

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jan 14, 2024

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

Co-authored-by: Marko Bekhta <marko-bekhta@users.noreply.github.com>
Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress! I've added a few comments inline.

Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thanks for your work! I think we are nearly there. There are a few inline comments, mostly about the style to align things with the existing code. And also, we'd want to add this new constraint to the documentation here:

`@NIP`:: Checks that the annotated character sequence represents a Polish VAT identification number (https://pl.wikipedia.org/wiki/NIP[NIP])

@ing9990 ing9990 closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants