-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HV-1970 Add Korean specific RRN annotation #1338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request.
This post on adding new constraints may be interesting to you, if you haven't seen it before: https://in.relation.to/2018/01/04/adding-new-constraint-to-engine/ . See the annotation processor and documentation steps in particular.
Also, maybe you could update the ValidationMessages_ko.properties
file with the new message as well?
.../main/java/org/hibernate/validator/internal/constraintvalidators/hv/kor/KorRRNValidator.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/hibernate/validator/constraints/kor/KorRRN.java
Outdated
Show resolved
Hide resolved
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
Co-authored-by: Marko Bekhta <marko-bekhta@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress! I've added a few comments inline.
.../main/java/org/hibernate/validator/internal/constraintvalidators/hv/kor/KorRRNValidator.java
Show resolved
Hide resolved
...a/org/hibernate/validator/test/internal/constraintvalidators/hv/kor/KorRRNValidatorTest.java
Outdated
Show resolved
Hide resolved
...a/org/hibernate/validator/test/internal/constraintvalidators/hv/kor/KorRRNValidatorTest.java
Outdated
Show resolved
Hide resolved
…refactoring test codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thanks for your work! I think we are nearly there. There are a few inline comments, mostly about the style to align things with the existing code. And also, we'd want to add this new constraint to the documentation here:
hibernate-validator/documentation/src/main/asciidoc/ch02.asciidoc
Lines 759 to 760 in 729cd01
`@NIP`:: Checks that the annotated character sequence represents a Polish VAT identification number (https://pl.wikipedia.org/wiki/NIP[NIP]) |
Jira-(HV-1970)
Hai I tried to add Korean specific @rrn annotation.
I added annotation, validator, testcases, messages, etc.