Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-17157 - Remove the note on the jpamodelgen dependency #184

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

HHH-17157 - Remove the note on the jpamodelgen dependency #184

wants to merge 2 commits into from

Conversation

jrenaat
Copy link
Contributor

@jrenaat jrenaat commented Sep 28, 2023

as it is incorrect, and now also better explained in the user guide

yrodiere and others added 2 commits September 25, 2023 18:19
@yrodiere
[HSEARCH] Update roadmap
7f5f73b
@jrenaat
HHH-17157 - Remove the note on the jpamodelgen dependency as it is in…
983893d 
…correct, and now also better explained in the user guide

Signed-off-by: Jan Schatteman <jschatte@redhat.com>
@beikov beikov changed the base branch from staging to production September 29, 2023 07:52
@beikov beikov changed the base branch from production to staging September 29, 2023 07:53
@jrenaat jrenaat changed the base branch from staging to production October 3, 2023 12:15
yrodiere
yrodiere requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a rebase issue, because removing stuff from the Hibernate Search roadmap doesn't seem appropriate here :]

@jrenaat
Copy link
Contributor Author

jrenaat commented Mar 1, 2024

I think there was a rebase issue, because removing stuff from the Hibernate Search roadmap doesn't seem appropriate here :]

Who rebased it? I know I didn't ... 🤷

@yrodiere
Copy link
Member

yrodiere commented Mar 1, 2024

I think there was a rebase issue, because removing stuff from the Hibernate Search roadmap doesn't seem appropriate here :]

Who rebased it? I know I didn't ... 🤷

image

@jrenaat
Copy link
Contributor Author

jrenaat commented Mar 1, 2024 •
edited

I think there was a rebase issue, because removing stuff from the Hibernate Search roadmap doesn't seem appropriate here :]

Who rebased it? I know I didn't ... 🤷

image

Dohhh
I cannot confirm nor deny ...

@jrenaat
Copy link
Contributor Author

jrenaat commented Mar 1, 2024

Either way, I'm not sure if this PR isn't outdated already, since the jpamodelgen dep thing has changed since then (innm), I'd have to ask steve ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere requested changes

@sebersole sebersole Awaiting requested review from sebersole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jrenaat @yrodiere