Handle shutdown sockets #2171
Handle shutdown sockets #2171
Conversation
dlon
force-pushed
the
handle-shutdown-sockets
branch
from
b156b1c
to
1cb319e
Compare
|
Did you remove all the TCP handling stuff? I think that would still be good to keep. |
dlon
force-pushed
the
handle-shutdown-sockets
branch
from
1cb319e
to
8d8c8d0
Compare
Done. I skipped quic and h3 since they don't seem to forward any meaningful error. |
|
Would it be possible to have a patch release with this fix in it published? The socket closing cause us significant issues. For now we depend on the git repository, but we want to depend on a crates.io release if possible 🙏 |
|
Sorry for the slow respons -- @bluejekyll seems to be very busy right now -- not sure if he will be able to publish to crates.io (or give me access, maybe via a GitHub team)? If so we can probably make this happen. |
|
Hey @faern -- sorry for the delay in getting back to you. Apparently we should be able to release from the Actions workflow if I tag a release, so I can (try) to do it after all. Can you try a backport PR? I've pushed a |
Fix #2169. The server stops accepting connections if this fails due to an unrecoverable error. The list of "unrecoverable" errors might not be exhaustive.