Add proxy support #1436
Open
Add proxy support #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow for parallel installation of debug and production builds
This commit adds support for proxying network requests over a SOCKS or HTTP proxy and the corresponding preferences screen. A DelegatingProxy (which is a java.net.Proxy) is registered on every RestService. The DelegatingProxy delegates its proxying to a real Proxy created from the proxy preferences. This implementation is a bit ugly but the fact that RestServices are only created once while proxy preferences can change at any time made it hard to avoid global state and the DelegatingProxy class. Enabling proxying breaks search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for proxying network requests over a SOCKS or HTTP proxy and the corresponding preferences screen.
A DelegatingProxy (which is a java.net.Proxy) is registered on every RestService. The DelegatingProxy delegates its proxying to a real Proxy created from the proxy preferences.
This implementation is a bit ugly but the fact that RestServices are only created once while proxy preferences can change at any time made it hard to avoid global state and the DelegatingProxy class.
Enabling proxying breaks search. I haven't investigated this further but it works without a proxy.