Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards/mqtt demo #21027

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open

Dashboards/mqtt demo #21027

wants to merge 72 commits into from

Conversation

jomar-honsi
Copy link
Collaborator

@jomar-honsi jomar-honsi commented Apr 17, 2024

MQTT data -> Data pool -> Dash components.

@highsoft-bot
Copy link
Collaborator

Webpack monitoring

LGTM 👍

@highsoft-bot
Copy link
Collaborator

File size comparison

No differences found

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Apr 17, 2024

Lighthouse report

dashboards-demo-minimal.json

Reference Proposed Diff
performance – score 1 1 0.00
first-contentful-paint – score 1 1 0.00
first-contentful-paint – milliseconds 189.22 187.96 -1.26
first-meaningful-paint – score 1 1 0.00
first-meaningful-paint – milliseconds 454.04 444.91 -9.13
dom-size – score 1 1 0.00
dom-size – elements 346 346 0.00

@highsoft-bot
Copy link
Collaborator

highsoft-bot commented Apr 17, 2024

Dashboard visual diffs

No differences found

<script src="https://code.highcharts.com/modules/solid-gauge.js"></script>
<script src="https://code.highcharts.com/modules/accessibility.js"></script>

<script src="https://cdnjs.cloudflare.com/ajax/libs/paho-mqtt/1.0.1/mqttws31.js" type="text/javascript"></script>

Check warning

Code scanning / CodeQL

Inclusion of functionality from an untrusted source Medium

Script loaded from content delivery network with no integrity check.
@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@jomar-honsi jomar-honsi marked this pull request as draft April 19, 2024 10:04
@jomar-honsi jomar-honsi marked this pull request as ready for review June 6, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Dash
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants