dash/datagrid2 #21182
Draft
dash/datagrid2 #21182
+2,556
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File size comparisonSizes for compiled+gzipped (bold) and compiled files.
|
Visual test results - No difference found |
Dash/datagrid2 benchmark
|
|
||
| if (value !== void 0) { | ||
| if (key === 'style') { | ||
| Object.assign(element.style, value); |
There was a problem hiding this comment.
Spread operator should be faster.
| const element = document.createElement(tagName); | ||
|
|
||
| if (params) { | ||
| const paramsKeys = Object.keys( |
There was a problem hiding this comment.
We can try to test Object.entries instead. It should be faster.
stitot
reviewed
May 27, 2024
stitot
reviewed
May 28, 2024
There was a problem hiding this comment.
Great work!
- When writing api docs please stick to the convention:
/**
* Constructs a row in the data grid.
*
* @param dataGrid
* The data grid instance which the row belongs to.
*
* @param index
* The index of the row in the data table.
*/- I would like to have some convention about the class lifecycle methods:
- have "light"
constructorthat callsinit initshould set some basic options and callloadand/orrenderupdatemethod is missingreflowI don't like it, buf if we need it let's keep itdestroyis missing?
| public viewport: DataGridTable; | ||
|
|
||
| /** | ||
| * The width ratio of the column. |
There was a problem hiding this comment.
Could you please explain a bit more what it does and why?
As far as I see there is no way to set it right?
| /** | ||
| * Whether the row is destroyed. | ||
| */ | ||
| public destroyed: boolean = false; |
There was a problem hiding this comment.
destroyed for me seems permanent and completed, I would use something like removed/hidden/notVisibleInViewport?
…w-heights dash/datagrid2-different-row-heights
…scrolling dash/datagrid2-td-resizing-scrolling
dash/datagrid2-styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP
(ToDo list moved to Asana)