Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to sort traces #8497

Merged
merged 25 commits into from May 13, 2024
Merged

Conversation

ccschmitz
Copy link
Contributor

Summary

Allows users to sort traces by clicking the column headers of the traces table.

https://www.loom.com/share/cd09c436b33548d0bdf6add86439a98e

How did you test this change?

  • Click table headers to trigger sorting
    • Ensure results are sorted correctly
    • Ensure that scrolling loads the correct results
  • Ensure scrolling backward on logs loads the correct results
  • Ensure all results load as expected for logs and traces

Are there any deployment considerations?

We will want to monitor performance when using sorting. My testing was in development without a lot of data, but it could have a more drastic negative impact on performance in production.

Does this work require review from our design team?

Have been discussing the UX of table headers w/ @julian-highlight in https://linear.app/highlight/issue/HIG-4525/improvements-to-table-headers which will include some additional changes to table headers.

Copy link

linear bot commented May 7, 2024

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 35f0373

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@ccschmitz
Copy link
Contributor Author

@mayberryzane ready for another look whenever you have time!

@ccschmitz ccschmitz merged commit 73d46ef into main May 13, 2024
21 checks passed
@ccschmitz ccschmitz deleted the hig-4572-allow-users-to-sort-by-duration branch May 13, 2024 16:45
ccschmitz added a commit that referenced this pull request May 13, 2024
ccschmitz added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants