Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Java SDK #8541

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cleanup Java SDK #8541

wants to merge 3 commits into from

Conversation

NgLoader
Copy link
Contributor

@NgLoader NgLoader commented May 11, 2024

chore: cleanup some classes
fix: code spacing in some classes

Summary

Cleanup the java sdk and add some missing commands.
Also made the servername optionaly.

How did you test this change?

Localy

Are there any deployment considerations?

No

Does this work require review from our design team?

No

chore: format code spacing
Copy link

changeset-bot bot commented May 11, 2024

⚠️ No Changeset found

Latest commit: 460a7b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "rrdom" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrdom-nodejs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-player" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrweb-snapshot" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/types" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@rrweb/web-extension" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "rrvideo" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

chore: removed duplicated code
@Vadman97
Copy link
Member

/tip $100

@Vadman97 Vadman97 self-requested a review May 13, 2024 21:32
Copy link

algora-pbc bot commented May 13, 2024

@NgLoader: You just got a $100 tip! 👉 Complete your Algora onboarding to collect your payment.

Copy link
Member

@Vadman97 Vadman97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far!

@Vadman97 Vadman97 self-assigned this May 13, 2024
@NgLoader NgLoader marked this pull request as ready for review May 17, 2024 16:33
@NgLoader
Copy link
Contributor Author

NgLoader commented May 17, 2024

Hey, sry for the delay.
I had planed some more small changes but will merge them inside some other PRs.
Need to do some other work first but soon I will commit some new implementations (framework / logger support) in java.

Copy link

algora-pbc bot commented May 18, 2024

🎉🎈 @NgLoader has been awarded $100! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants