-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(cpp) fix class/template parsing issues (#2752)
* fix(cpp) fix class/template parsing issues. Fixes #2716. Fixes #2102. * enh(cpp) add support for `enum struct` and `enum class` * add support for `union` * minor file ending with CR changes for some `markup` tests
- Loading branch information
1 parent
1475886
commit 6d6b8a6
Showing
10 changed files
with
58 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<span class="hljs-keyword">template</span> <<span class="hljs-class"><span class="hljs-keyword">class</span> <span class="hljs-title">T</span>></span> <span class="hljs-comment">// comment</span> | ||
<span class="hljs-function"><span class="hljs-keyword">auto</span> <span class="hljs-title">foo</span><span class="hljs-params">(T x)</span> </span>{ ... }; | ||
|
||
<span class="hljs-keyword">namespace</span> impl { | ||
<span class="hljs-keyword">template</span><<span class="hljs-keyword">typename</span> T> | ||
<span class="hljs-class"><span class="hljs-keyword">struct</span> <span class="hljs-title">is_streamable</span><</span>T, <span class="hljs-built_in">std</span>::<span class="hljs-keyword">void_t</span><<span class="hljs-keyword">decltype</span>(<span class="hljs-built_in">std</span>::declval<<span class="hljs-built_in">std</span>::wostream &>() << <span class="hljs-built_in">std</span>::declval<T>())>> : <span class="hljs-built_in">std</span>::true_type { }; | ||
} | ||
|
||
<span class="hljs-comment">// Disable overload for already valid operands.</span> | ||
<span class="hljs-keyword">template</span><<span class="hljs-class"><span class="hljs-keyword">class</span> <span class="hljs-title">T</span>, <span class="hljs-keyword">class</span> =</span> <span class="hljs-built_in">std</span>::<span class="hljs-keyword">enable_if_t</span><!impl::is_streamable_v<<span class="hljs-keyword">const</span> T &> && <span class="hljs-built_in">std</span>::is_convertible_v<<span class="hljs-keyword">const</span> T &, <span class="hljs-built_in">std</span>::wstring_view>>> | ||
<span class="hljs-built_in">std</span>::wostream &<span class="hljs-keyword">operator</span> <<(<span class="hljs-built_in">std</span>::wostream &stream, <span class="hljs-keyword">const</span> T &thing) | ||
{ | ||
<span class="hljs-keyword">return</span> stream << <span class="hljs-keyword">static_cast</span><<span class="hljs-built_in">std</span>::wstring_view>(thing); | ||
} | ||
|
||
<span class="hljs-class"><span class="hljs-keyword">enum</span> <span class="hljs-keyword">struct</span> <span class="hljs-title">DataHolder</span> {</span> }; | ||
<span class="hljs-class"><span class="hljs-keyword">enum</span> <span class="hljs-keyword">class</span> <span class="hljs-title">DataThingy</span> {</span> }; | ||
<span class="hljs-class"><span class="hljs-keyword">enum</span> <span class="hljs-keyword">class</span> <span class="hljs-title">Boolean</span> :</span> <span class="hljs-keyword">char</span> { | ||
True, False, FileNotFound | ||
}; | ||
|
||
<span class="hljs-class"><span class="hljs-keyword">union</span> <span class="hljs-title">Soy</span> | ||
{</span> | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
template <class T> // comment | ||
auto foo(T x) { ... }; | ||
|
||
namespace impl { | ||
template<typename T> | ||
struct is_streamable<T, std::void_t<decltype(std::declval<std::wostream &>() << std::declval<T>())>> : std::true_type { }; | ||
} | ||
|
||
// Disable overload for already valid operands. | ||
template<class T, class = std::enable_if_t<!impl::is_streamable_v<const T &> && std::is_convertible_v<const T &, std::wstring_view>>> | ||
std::wostream &operator <<(std::wostream &stream, const T &thing) | ||
{ | ||
return stream << static_cast<std::wstring_view>(thing); | ||
} | ||
|
||
enum struct DataHolder { }; | ||
enum class DataThingy { }; | ||
enum class Boolean : char { | ||
True, False, FileNotFound | ||
}; | ||
|
||
union Soy | ||
{ | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,4 +20,4 @@ SQL</span>); | |
var_dump(<span class="hljs-string"><<<SQL | ||
SELECT * | ||
FROM table | ||
SQL</span>); | ||
SQL</span>); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,4 @@ | |
<span class="hljs-comment">/* | ||
test multiline | ||
comment | ||
*/</span> | ||
*/</span> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
<span class="hljs-function"><span class="hljs-keyword">def</span> <span class="hljs-title">f</span>(<span class="hljs-params">x: <span class="hljs-built_in">int</span>, *, y: <span class="hljs-built_in">bool</span> = <span class="hljs-literal">True</span></span>) -> <span class="hljs-keyword">None</span>:</span> | ||
<span class="hljs-keyword">pass</span> | ||
<span class="hljs-keyword">pass</span> |