Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support highlighting inline HTML and CSS tagged template strings in JS and TS #2105

Merged
merged 3 commits into from Aug 16, 2019
Merged

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Aug 16, 2019

Also copies over the JavaScript parser's support for nested template strings into the TypeScript parser.

Includes tests for all three scenarios.

With libraries like lit-html, htm, hyperHTML, and others, it's becoming common to write inline HTML and CSS as tagged template literals in source code. This change adds support for highlighting such code as HTML and CSS using highlight.js's inline language support.
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@marcoscaceres marcoscaceres merged commit 3e78df7 into highlightjs:master Aug 16, 2019
@rictic rictic deleted the template-strings branch August 16, 2019 21:04
@rictic
Copy link
Contributor Author

rictic commented Aug 16, 2019

Thanks for the quick review!

@marcoscaceres
Copy link
Contributor

Will try to publish a new release in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants