Support highlighting GraphQL tagged template strings in JS/TS code #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable so far... |
ali
commented
Feb 10, 2023
|
Thanks for taking an early look at this @joshgoebel! I finished updating the test files and confirmed everything is working locally. This PR is now ready for review. |
joshgoebel
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for highlighting GraphQL tagged template strings in JS/TS code.
I wired this up in a way that's similar to #2105.
Related to PRs #2105 and #3448, and issue #1471 (general GraphQL support).
Changes
Checklist
CHANGES.md