New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(csharp) Add all v9 keywords, and other missing keywords #2679
enh(csharp) Add all v9 keywords, and other missing keywords #2679
Conversation
Very nice. |
Hi again @joshgoebel - thank you very much! I've fixed all the broken tests that I caused, this should be good to go now. Thanks again. |
Hi @joshgoebel - assuming this gets merged, how long until it is published as an official package update? |
@IEvangelist FYI, if you're asking to get this on the official docs, I think docs uses this fork, so the fork needs to first get updated with upstream. (there should be additional steps which I don't know) |
Hi @Youssef1313 - I'm familiar with that and in fact, we're trying to evaluate potentially reverting back to using this primary fork. Hence the reason why I'm focusing on adding some updates here. The fork has about 650 delta-commits, and we've added a ton of custom languages. We are exploring the extension model to see if we could plug in and revert back. |
That sounds great! Thanks for letting me know. |
We do minor releases every 45 days or so and we just did a release. |
Hey @Youssef1313 and @joshgoebel , right now we build a subset of languages into a single version of highlight.js that we use on Docs, including some of our custom ones. In the V10 world, with those languages stored elsewhere, is there a build command/process for producing that same single highlight.js file? I was looking at https://highlightjs.readthedocs.io/en/latest/building-testing.html, but didn't see any mention of 3rd party hosted language syntaxes |
@DuncanmaMSFT See the 3rd_party_quickstart. The normal build process will "just work" if additional language libraries are checked out out into If you just wanted to hack it you might create a structure like:
They'll likely need to be ES6 modules now of course, etc. It's also possible symlinks might work, but that's never been tested. |
@DuncanmaMSFT And no more IE11 with version 10 of course. |
Thanks @joshgoebel , for both responses, this is great. The IE11 issue isn't necessarily a blocker for us, since the code snippets would still be there and the page would work, it just wouldn't be syntax highlighted and that doesn't seem like a blocker for that specific browser (< 5% of our traffic all up, but < 2% in an area of the site like /dotnet/) |
Hi 👋🏼 highlight.js friends!
I'd like to introduce several new C# keywords. These are being added as part of C# 9.
init
record
and
not
or
nint
nunit
with
default
as literal, etc.)built_in
keywordsSee our official docs: https://docs.microsoft.com/dotnet/csharp/whats-new/csharp-9