Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing the new C# 9 keywords #2676

Closed
wants to merge 2 commits into from
Closed

Introducing the new C# 9 keywords #2676

wants to merge 2 commits into from

Conversation

IEvangelist
Copy link
Contributor

@IEvangelist IEvangelist commented Sep 8, 2020

Hi 馃憢馃徏 highlight.js friends!

I'd like to introduce several new C# keywords. These are being added as part of C# 9.

  • init
  • record
  • and
  • not
  • or
  • nint
  • nunit
  • with

See our official docs: https://docs.microsoft.com/dotnet/csharp/whats-new/csharp-9

@IEvangelist IEvangelist changed the title Introducing the new C# 8 keywords Introducing the new C# 9 keywords Sep 8, 2020
Added missing `with` keyword too
@joshgoebel
Copy link
Member

Looks good. Could you add a CHANGES.md entry please?

Also, is there any chance you'd mind grouping all the "datatype" keywords as well (since you seem to know C#) and perhaps it'd be quick for you to do?

In the future we should probably highlight them as data types instead of keywords proper, what do you think?

@IEvangelist
Copy link
Contributor Author

Hi @joshgoebel - I can update the CHANGES.md, no problem. I'm not sure I follow the other suggestions - as I'm not that familiar with how some of the internals work in highlight.js.

  • What is this datatype keyword you speak of and how do I group things as that?

@joshgoebel
Copy link
Member

joshgoebel commented Sep 9, 2020

I'm not sure I follow the other suggestions - as I'm not that familiar with how some of the internals work in highlight.js.

Well for starters I just meant grouping them literally, with a comment (like the keywords are already grouped into normal vs contextual)... but really we probably should highlight them as "type" or "built_in"... but getting them grouped first would be a step in that direction.

@IEvangelist
Copy link
Contributor Author

I'm going to close and reopen a new PR, properly forking the repo.

@IEvangelist IEvangelist closed this Sep 9, 2020
@IEvangelist
Copy link
Contributor Author

Hey @joshgoebel - see #2679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants