automate a common build process to check for "use strict" safe code #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
test_use_strict_safe
branch
from
3e85db6
to
41b08c4
Compare
joshgoebel
changed the title
joshgoebel
force-pushed
the
test_use_strict_safe
branch
from
ce6e8bb
to
f7009ad
Compare
joshgoebel
changed the title
- Adds a test to the CI pipeline that builds a "typical" consolidated Highlight.js package from the full NPM source and then checks that that build actually executes without errors Related to highlightjs#2247.
joshgoebel
force-pushed
the
test_use_strict_safe
branch
from
f7009ad
to
1a57637
Compare
|
Related: #2247 @egor-rogov If you have thoughts on naming or a better approach here I'm all ears. We could build the executable in |
egor-rogov
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight.js package from the full NPM source and then checks that
that build actually executes without errors