Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) When ignoring a potential match highlighting can terminate early #2650

Merged
merged 4 commits into from
Sep 5, 2020
Merged

(fix) When ignoring a potential match highlighting can terminate early #2650

merged 4 commits into from
Sep 5, 2020

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Aug 9, 2020 •
edited

Resolves #2649.

  • add test

@joshgoebel joshgoebel mentioned this pull request Aug 9, 2020
Closed
@joshgoebel joshgoebel added this to the 10.2 milestone Aug 17, 2020
@joshgoebel
Copy link
Member Author

@allejo @egor-rogov Approve/reject? :-) Would like to do a release in a few days.

egor-rogov
egor-rogov approved these changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joshgoebel joshgoebel merged commit 730f891 into highlightjs:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.2
Development

Successfully merging this pull request may close these issues.

(parser) continueScanAtSamePosition can break highlighting if no other matches are found
3 participants
@joshgoebel @allejo @egor-rogov