Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Builds ES and CJS modules side by side with conditional exports #3007

Merged
merged 19 commits into from
Apr 16, 2021
Merged

(chore) Builds ES and CJS modules side by side with conditional exports #3007

merged 19 commits into from
Apr 16, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Feb 15, 2021 •
edited

Researching #2600.

Changes

  • Builds ES and CJS modules side by wide
  • Uses conditional exports

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel marked this pull request as draft February 15, 2021 01:09
@joshgoebel joshgoebel added 0-WIP package/build Issues relating to npm or packaging labels Feb 15, 2021
@joshgoebel joshgoebel added this to the 11.0 milestone Feb 15, 2021
@joshgoebel joshgoebel linked an issue Feb 15, 2021 that may be closed by this pull request
Discuss: Should Highlight.js version 11 npm release be ESM only? #2600
Closed
@aduh95
Copy link
Contributor

aduh95 commented Feb 15, 2021

You need to change

highlight.js/package.json

Line 23 in 6af784f

"main": "./lib/index.js",

to use the .mjs instead (or keep using the .js extension and add "type":"module" to the package.json).

@aduh95 aduh95 mentioned this pull request Feb 15, 2021
Closed
4 tasks
@joshgoebel joshgoebel removed the 0-WIP label Feb 18, 2021
Base automatically changed from master to main March 18, 2021 17:26
@joshgoebel joshgoebel mentioned this pull request Mar 24, 2021
Closed
@joshgoebel joshgoebel changed the title (chore) Build ESM modules instead of CJS modules (chore) Builds ES and CJS modules side by side with conditional exports Mar 24, 2021
aduh95
aduh95 reviewed Mar 24, 2021
View reviewed changes
tools/build_node.js Outdated Show resolved Hide resolved
tools/build_node.js Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Mar 24, 2021
View reviewed changes
tools/build_node.js Outdated Show resolved Hide resolved
@joshgoebel
Copy link
Member Author

Good?

@joshgoebel joshgoebel marked this pull request as ready for review March 25, 2021 08:19
@joshgoebel joshgoebel requested a review from allejo March 25, 2021 08:37
@joshgoebel joshgoebel modified the milestones: 11.0, 11.0 alpha 1 Mar 28, 2021
@joshgoebel joshgoebel self-assigned this Apr 5, 2021
aduh95
aduh95 reviewed Apr 6, 2021
View reviewed changes
tools/build_node.js Outdated Show resolved Hide resolved
tools/build_node.js Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Apr 6, 2021
View reviewed changes
tools/build_node.js Outdated Show resolved Hide resolved
@joshgoebel joshgoebel modified the milestones: 11.0 alpha 1, 11.0 Apr 13, 2021
@joshgoebel joshgoebel added this to To Do in Version 11 Apr 14, 2021
@joshgoebel joshgoebel moved this from To Do to In Progress in Version 11 Apr 14, 2021
@joshgoebel joshgoebel moved this from In Progress to Waiting merge in Version 11 Apr 14, 2021
@joshgoebel joshgoebel removed this from the 11.0 milestone Apr 14, 2021
@joshgoebel joshgoebel added this to the 11.0 alpha 1 milestone Apr 14, 2021
joshgoebel and others added 18 commits April 16, 2021 11:47
@joshgoebel
build ES modules for npm
cc6e84c
@joshgoebel
goodbye legacy lib/highlight.js
7072a2f
@joshgoebel
probably time to say goodbye to loader
bdbc503
@joshgoebel
build common separately
6e52ba7
@joshgoebel
update naming in package.json
470d57a
@joshgoebel
dual build
4a15f7b
@joshgoebel
add a few more files to our pkg
c65afea
@joshgoebel
do not make imports ugly if we can avoid it
66185cf
@joshgoebel
export package.json
7e2ff68
@joshgoebel
must export default now
9128404
@joshgoebel @aduh95
Update tools/build_node.js
f971772 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joshgoebel
fixup
e019d1e
@joshgoebel
add lib/common to the readme
c465bd4
@joshgoebel
add --no-esm build option
f529e78
@joshgoebel
add package.json to ES module folder
ff60eb4
@joshgoebel
add .js.js stubs for maximum compatible with requires using extensions
b087e0a
@joshgoebel @aduh95
Update tools/build_node.js
715a0bb 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joshgoebel @aduh95
Update tools/build_node.js
f4e9a57 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@joshgoebel joshgoebel merged commit 6a7c0e6 into highlightjs:main Apr 16, 2021
Version 11 automation moved this from Waiting merge/review to Done Apr 16, 2021
@benmccann benmccann mentioned this pull request Apr 20, 2021
Closed
@fregante fregante mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@allejo allejo Awaiting requested review from allejo

Assignees

@joshgoebel joshgoebel

Labels
package/build Issues relating to npm or packaging
Projects
Version 11
Done
Milestone
11.0 alpha 1
Development

Successfully merging this pull request may close these issues.

Discuss: Should Highlight.js version 11 npm release be ESM only?
2 participants
@joshgoebel @aduh95