enh(java) support functions with nested template types #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
java_nested_generic
branch
from
34b5b91
to
e9ffc4f
Compare
allejo
approved these changes
Apr 6, 2021
| * @returns {string}`` | ||
| */ | ||
| function recurRegex(re, substitution, depth) { | ||
| if (depth === -1) return ""; |
There was a problem hiding this comment.
Suggested change
| if (depth === -1) return ""; | |
| if (depth < 0) return ""; |
There was a problem hiding this comment.
I don't think this is an improvement. I'd rather be precise.
It accounts for the examples I was given. If your example is common then we can bump the # slightly but there is no need for it to be higher than it should be. Bump it to 2? |
joshgoebel
force-pushed
the
java_nested_generic
branch
from
afa3c49
to
ca853fa
Compare
|
Can’t speak for everyone but I see deeply nested types all the time in my work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2641.
Changes
Allows Java template types for functions to be recursive a single level:
IE (Token within List):
Checklist
CHANGES.md