(chore) min change threshold for size report #3401
Conversation
|
Shouldn't we et a size report for this change? (even though it obviously won't change anything) |
|
It looks like the workflow ran - it probably doesn't comment if there's no changes. |
|
Error: compressed-size-action was unable to comment on your PR. |
|
I'll look into this a bit more to see if there's a workaround in GitHub actions - I apologise for this oversight. |
Did you learn anything? |
|
I'm merging since it's the right idea, even if it's not working properly yet. |
* master: (816 commits) (chore) add sideEffects: false to enable tree-shaking in esbuild & others fix(markdown) Handle `***Hello world***` without breaking (highlightjs#3457) (chore) DRY up php grammar just a little enh(php) support CSSCase attribute naming refactor, security issues enh(php) Add support for Attributes fix(java) prevent false variable init on `else` (highlightjs#3455) (ci) min change threshold for size report (highlightjs#3401) (themes) Add `tokyo-night-dark` (highlightjs#3467) enh(llvm) Improve number support, add `char.escape` (highlightjs#3471) (chore) simplify brainfuck grammar fix(brainfuck) fix highlighting of initial ++/-- Minor change to TypeScript types and TypeScript-specific keywords (highlightjs#3466) fix(angelscript) Fix highlighting of int8, int16, int32, int64 (highlightjs#3464) enh(php) named arguments and fix php constants (highlightjs#3459) themes: add new felipec theme (highlightjs#3441) (chore) release 10.4.0 enh(arcade) Add missing keywords for Arcade v1.16 chore(arcade) eslint --fix, explode keywords enh(php) Left and right-side of double colon (highlightjs#3422) ...
|
@joshgoebel Sorry for never getting round to this, this project fell off my radar for a bit! I'll still try to look into this after I work on a few outstanding grammar-level changes needed to Swift. |
±5 byte threshold to avoid reports for hash changes and tiny edits.
Changes
Checklist