Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(php) some PHP cleanups #3427

Merged
merged 9 commits into from
Dec 10, 2021
Merged

Commits on Dec 10, 2021

  1. Configuration menu
    Copy the full SHA
    7a06bad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4a068b View commit details
    Browse the repository at this point in the history
  3. chore(php) comments should not care about pre-processor

    - this should be handled by php-template level (not php)
    joshgoebel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    e158fbd View commit details
    Browse the repository at this point in the history
  4. chore(php) remove dead contains rule

    This rule wasn't even being used since each of the variants
    already has it's own contains, so this one would never have
    a change to be "default".
    joshgoebel committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    f5616e1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6e116aa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    38ebe60 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5907a60 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fc6bcc9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c5e405f View commit details
    Browse the repository at this point in the history