Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Comments inside function invoke & declaration #3680

Closed
wants to merge 3 commits into from
Closed

PHP Comments inside function invoke & declaration #3680

wants to merge 3 commits into from

Conversation

doiftrue
Copy link
Contributor

PHP language not supported php comments inside function invoke and function declaration.

Changes

Added:
hljs.C_LINE_COMMENT_MODE
hljs.HASH_COMMENT_MODE

Was:
image

Become:
image

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Wow, did PHP go all comment agnostic? Is that new?

@doiftrue
Copy link
Contributor Author

Wow, did PHP go all comment agnostic?

I'm not quite sure what is meant by the word "agnostic".

Is that new?

No, it's not a new feature, adding comments anywhere in the code has always been supported as far as I know.

@joshgoebel joshgoebel force-pushed the php-comments-in-function branch 2 times, most recently from 926e298 to fddcf53 Compare March 19, 2023 15:42
joshgoebel
joshgoebel approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add an entry to the CHANGLOG as well!

@joshgoebel joshgoebel added the awaiting changes Awaiting changes by PR author label Mar 19, 2023
@joshgoebel
Copy link
Member

Ping.

@joshgoebel
Copy link
Member

Closing due to inactivity/lack of response. If you return and have time we're happy to reopen this in the future.

@joshgoebel joshgoebel closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
awaiting changes Awaiting changes by PR author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doiftrue @joshgoebel