Address issue #814 #1072
Open
Address issue #814 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `showMousePosition` option is set to `true` and the mouse pointer moves over a non-2d track, x and y values are published internally that can cause another 2d track to draw nonsensical vertical or horizontal lines. This test clears the relevant value so that it cannot be used to render such lines.
|
Looks good! Gotta fix the dang tests (not your fault). Let me try to do that over the weekend and then we can merge it. Unless it's urgent. |
|
Not urgent at all, just wanted to scratch a two year old itch!
… On Dec 2, 2021, at 20:15, Peter Kerpedjiev ***@***.***> wrote:
Looks good! Gotta fix the dang tests (not your fault). Let me try to do that over the weekend and then we can merge it. Unless it's urgent.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
showMousePositionoption is set totrueand the mouse pointer moves over a non-2d track, x and y values are published internally that can cause another 2d track to draw nonsensical vertical or horizontal lines. This test clears the relevant value so that it cannot be used to render such lines.Fixes #814
Checklist