Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the hideTrackChooser API call #775

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixed the hideTrackChooser API call #775

wants to merge 3 commits into from

Conversation

pkerpedjiev
Copy link
Member

Description

What was changed in this pull request?

The previous hideTrackChooser API call was calling a non-existent this object. This PR fixes it and adds a test.

Why is it necessary?

Prevent an error when calling hideTrackChooser.

Fixes #___

Checklist

  • Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
  • Unit tests added or updated
  • Documentation added or updated
  • Example(s) added or updated
  • Update schema.json if there are changes to the viewconf JSON structure format
  • Screenshot for visual changes (e.g. new tracks or UI changes)
  • Updated CHANGELOG.md

flekschas
flekschas approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@flekschas flekschas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flekschas flekschas flekschas approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkerpedjiev @flekschas