Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons for selecting upper-right or lower-left extent when adding center track #826

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

keller-mark
Copy link
Member

Description

What was changed in this pull request?

Buttons for selecting the upper-right or lower-left extent were added to the center square of the add track position pop-up menu. The behavior of HiGlassComponent.adjustOtherTrackOptions had to be slightly modified (https://github.com/higlass/higlass/compare/develop...keller-mark:keller-mark/add-center-track-with-extent?expand=1#diff-77a44232595309f20e1f8787348f2734L3179) to prevent infinite loops.

Why is it necessary?

Not necessary, just an enhancement.

Fixes #759

Screenshots

No hover:
Screen Shot 2020-01-14 at 10 59 18 AM

Hover over center:
Screen Shot 2020-01-14 at 10 59 25 AM

Hover over upper right triangle:
Screen Shot 2020-01-14 at 10 59 32 AM

Hover over lower left triangle:
Screen Shot 2020-01-14 at 10 59 39 AM

Checklist

  • Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
  • Unit tests added or updated
  • Documentation added or updated
  • Example(s) added or updated
  • Update schema.json if there are changes to the viewconf JSON structure format
  • Screenshot for visual changes (e.g. new tracks or UI changes)
  • Updated CHANGELOG.md

@pkerpedjiev
Copy link
Member

Nice addition! Would you mind adding a section to the docs describing this?

A mention here: https://github.com/higlass/higlass/blob/develop/docs/tutorial.rst
And a more detailed description with a screenshot here: https://github.com/higlass/higlass/blob/develop/docs/views.rst

@keller-mark keller-mark marked this pull request as ready for review January 14, 2020 17:39
@keller-mark
Copy link
Member Author

Thanks! I have added some info about this to both of those places.

docs/tutorial.rst Outdated Show resolved Hide resolved
docs/views.rst Outdated Show resolved Hide resolved
keller-mark and others added 5 commits January 15, 2020 12:10
Co-Authored-By: Peter Kerpedjiev <pkerpedjiev@gmail.com>
Co-Authored-By: Peter Kerpedjiev <pkerpedjiev@gmail.com>
@keller-mark keller-mark force-pushed the keller-mark/add-center-track-with-extent branch from 900a69b to 3cb002c Compare January 15, 2020 17:11
@pkerpedjiev
Copy link
Member

Would you mind adding a quick test to touch this functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an explicit button for the upper-right and lower-left extent
2 participants