Adding in showLegend export variable #56
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himynameisdave
added
Type: Feature
|
@MellenIO thanks for adding this. While I understand it wouldn't break anything here to merge this now, I would prefer to wait until it lands upstream first, as this is really just a wrapper around Having said this, I know the maintainers of Again, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off - thanks for this library, it's super useful!
I opened a PR for Frappe in relation to using their
showLegendoption - which is fully implemented, but not configurable.You can find it here: frappe/charts#389
I wanted to add this as a PR on the basis that it gets implemented. I don't think the library will break w/ this if the upstream PR isn't merged, but it would probably be best to only do so when upstream is merged.
Thanks!