Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass check name environment variable #113

Merged
merged 2 commits into from Mar 2, 2023
Merged

Allow to pass check name environment variable #113

merged 2 commits into from Mar 2, 2023

Conversation

PaulGiletich
Copy link
Contributor

@PaulGiletich PaulGiletich commented Mar 1, 2023 •
edited

this covers at least two use cases:

  1. For some people the check name may conflict with an existing one, if they are using their own github app.
  2. In some monorepos there are multiple jest runs happening in series for multiple different packages in scope of one codebuild run. Without an ability to override the check name we are stuck with only last package results being reported.

This would allow to work around those

related PR: hipstersmoothie/jest-github-reporter#150

@PaulGiletich PaulGiletich mentioned this pull request Mar 1, 2023
Merged
@PaulGiletich PaulGiletich changed the title Allow to pass env.GITHUB_CHECK_NAME Allow to pass check name environment variable Mar 1, 2023
@hipstersmoothie hipstersmoothie merged commit 4b959dd into hipstersmoothie:master Mar 2, 2023
@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Mar 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

🚀 PR was released in v1.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipstersmoothie hipstersmoothie hipstersmoothie approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PaulGiletich @hipstersmoothie