-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: segment not logging in prod #582
Conversation
71a10cc
to
72edc06
Compare
Build failure here is an active issue in webpack and in next tracked here: Last suggestion is to downgrade node to 16 in the Dockerfile. |
@CharlieC3 I got the build passing now if you want to test/approve. |
@fbwoolf I believe you're able to deploy to staging. Once you do we can see if it works 馃 |
Nope, not logging and Segment script is not in the header. Anything that would be different w/ staging vs production? |
045e01f
to
f3eb978
Compare
@fbwoolf I found an issue with the previous deployment caused by the GH org change. It should be fixed now for future staging deployments, but I had to manually deploy this branch. We'll encounter this issue for prod as well, so I may need to perform the next prod deployment. When you get a chance can you try it again? |
Didn't see this and was waiting to deploy again with a change I made, so your fix is likely what got it working I guess. Funny. Anyway, it is working now. |
Still a great success! Also I think the next deployment to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @CharlieC3 for all your help! |
馃帀 This PR is included in version 1.17.3 馃帀 The release is available on GitHub release Your semantic-release bot 馃摝馃殌 |
Thanks for posting this fix. I guess I need to start locking my alpine version to make sure my builds don't crash down the road for infrequently built apps. |
This PR should fix Segment in production 馃 . Moved rendering the snippet into the
_document
. Now able to use the node env var w/out theNEXT_PUBLIC_
syntax which would expose the write key in the browser.Issue #571