Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vite mergeConfig doesn't accept callback params #568

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: vite mergeConfig doesn't accept callback params #568

wants to merge 3 commits into from

Conversation

BBoehm
Copy link

@BBoehm BBoehm commented Jul 31, 2023 •
edited

Description

vite mergeConfig doesn't accept callback params.

This has already been fixed for version 0.16.2 here: dcd5d9f. It is a backport to version 14.

This is exactly the same fix from above for version 14, since versions >= 0.15.0 currently have an open bug on windows (#463).

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@codesandbox
Copy link

codesandbox bot commented Jul 31, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@stackblitz
Copy link

stackblitz bot commented Jul 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited

❌ Deploy Preview for histoire-examples-svelte3 failed.

Name Link
🔨 Latest commit 052d53f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/64c82d5bfbbfdb0007d2819f

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited

❌ Deploy Preview for histoire-examples-vue3 failed.

Name Link
🔨 Latest commit 052d53f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/64c82d5b9c6d140008fe319c

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited

❌ Deploy Preview for histoire-controls failed.

Name Link
🔨 Latest commit 052d53f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/64c82d5b255bcd00083e6f95

@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited

❌ Deploy Preview for histoire-site failed.

Name Link
🔨 Latest commit 052d53f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/64c82d5bb49cbe0008bb8507

BBoehm referenced this pull request Jul 31, 2023
@Akryum
fix: vite mergeConfig doesn't accept callback params
dcd5d9f
@BBoehm BBoehm mentioned this pull request Aug 25, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@BBoehm