feat: story stat counter #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you very much for this! 💚 I've reworked the design a little bit to be less "dramatic" and also support mobile. |
|
Thanks a lot for the feedback. I'm glad to contribute to such a great project 🤗💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've introduced a new feature on the Home screen that displays the counts of stories, variants, and documents. This provides users with an at-a-glance overview of the available content, aiding in quick decision-making. This works on all examples. Because this affects all examples, I wanted to write a unit test in packages/histoire-app, but I didn't find any test command in this package. I don't think that is a good idea to write tests in an example project because it doesn't test behaviour in other examples, that's why I was searching for tests in historie-app.
As reference guides for writing tests i use:
Additional context
Preview of the feature:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).