Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: if data has URL display it as hyperlink #140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: if data has URL display it as hyperlink #140

wants to merge 2 commits into from

Conversation

medjedovicm
Copy link

Resolves #131, resolves #132

Implementation

  • New segment type introduced link
  • Path or URL is detected and appropriate CSS is applied. (purple colour, text underlined)
  • In such case, the segment is clickable
  • When clicked, output event is fired: segmentLinkClicked payload is type string containing the clicked segment value

RamonHaugLand
RamonHaugLand approved these changes May 9, 2023
View reviewed changes
Copy link

@RamonHaugLand RamonHaugLand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but I also want the feautre.

src/ngx-json-viewer/ngx-json-viewer.component.ts Outdated
private isLink(value: string): boolean {
return value.substring(0, 8) === 'https://' ||
value.substring(0, 7) === 'http://' ||
value[0] === '/'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if this is changed to a RegExp, the scheme is not case sensitive, and is also posible http:(domain)
Reference

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was delayed a bit. I pushed and would appreciate your review.

@medjedovicm
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@RamonHaugLand RamonHaugLand RamonHaugLand approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If data has url how to display it as link (Hyperlink) Displaying hyperlinks
3 participants
@medjedovicm @allanbowe @RamonHaugLand