Fix big objects not expandable & expanded state reset when not needed #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a Set to store keys expanded on each level. This way, the parent stores expanded state of children & can keep state when the object changes, without resetting everything.
|
How does this work with duplicate keys? |
|
There's one set per object/array, so it can't have any duplicate keys. |
|
Could you please merge this pull request? 馃槂 @hivivo |
|
Hi, this repo looks dead, what do u think about open a new fork like ngx-json-viewer2 (if I'm not wrong the MIT licence allow it) and merge those PRs on that repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix introduce a Set that is used to store children's expanded state. If the
jsonproperty is changed with an object containing the same keys, the children's expanded state is preserved.Angular was updated to
>=8.0.0.Tell me if you need anything to merge this PR & publish the package. For info, it works well with quite heavy objects in my project.
For people passing by, you can install my build using the following command:
馃嵒 Cheers !