Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEC-1058 json library swap #36

Merged
merged 8 commits into from Sep 23, 2021
Merged

Conversation

meghana-viswanath
Copy link
Contributor

No description provided.

@meghana-viswanath meghana-viswanath marked this pull request as ready for review September 22, 2021 09:05
@meghana-viswanath
Copy link
Contributor Author

@AndyHWChung @priyankadhiman3006 I've added tests for the readers/writes in this commit, can you review them, thanks

@priyankadhiman3006
Copy link
Contributor

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

@meghana-viswanath
Copy link
Contributor Author

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Good question, I think it's better to do them all together @AndyHWChung ?

@AndyHWChung
Copy link
Contributor

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Yeah, we should merge everything together including updates to hec-ui-journey-tests where it's calling our BE test-only endpoint. It'd be a good idea just to clear our mongo databases in the test environments as well once it's merged in

@meghana-viswanath
Copy link
Contributor Author

Just a question, are we going to merge this now or will do the similar changes in other repos and then merge on the same day?
Cause if this merged and others may break when we try to validate tax code in LB.

Yeah, we should merge everything together including updates to hec-ui-journey-tests where it's calling our BE test-only endpoint. It'd be a good idea just to clear our mongo databases in the test environments as well once it's merged in

I'll keep this in Draft until we are ready to merge

@priyankadhiman3006
Copy link
Contributor

Then again, other code will keep on piling and you have to do rebase and stuff. i think we should divide and conquer :) happy to help

@meghana-viswanath meghana-viswanath marked this pull request as draft September 22, 2021 11:26
@meghana-viswanath meghana-viswanath marked this pull request as ready for review September 22, 2021 15:25
@meghana-viswanath meghana-viswanath merged commit 1bd9c44 into master Sep 23, 2021
@meghana-viswanath meghana-viswanath deleted the mv-hec-1058-json-library-swap branch September 23, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants