Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update router return statement to include type casting for next 14 app router #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OgDev-01
Copy link

@OgDev-01 OgDev-01 commented Feb 15, 2024

Fixes #241

This PR updates the readme to include a life saving section that fixes an error with h Next.js 14 app router in production/preview using typescript

Before

image

After

image

Copy link

changeset-bot bot commented Feb 15, 2024

⚠️ No Changeset found

Latest commit: 06bbeb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a56a9f9) 100.00% compared to head (06bbeb1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          436       436           
  Branches        60        60           
=========================================
  Hits           436       436           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OgDev-01 OgDev-01 marked this pull request as ready for review February 15, 2024 06:47
@OgDev-01
Copy link
Author

Hello @hoangvvo, Thanks for putting up this wonderful library 💯 . It has been a lifesaver for me since i started writing server code in nextjs.

I made a small update to the readme for a current issue we have with NextJS14 app router. This would prevent new/existing users who use nextjs 14 app router from facing issues with return type errors for the route handlers export.

Would you mind taking a look at this when you have the time?

Thanks 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App/Route issue "Promise<unknown>"
1 participant