This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
PHP 7 Upgrade: Return type error in the Bin/Client.php class.
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Bin/Client.php class, the return type for the `main` method is `:int`. But at line 79, there is a call to `$this->usage()` which return `void`. Since the value returned by that method is not compatible with the `main` signature, we get an error like : ``` Uncaught TypeError: Return value of Hoa\Websocket\Bin\Client::main() must be of the type integer, null returned ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the Bin/Client.php class, the return type for the
mainmethod is:int. But at line 79, there is a call to$this->usage()which returnvoid.Since the value returned by that method is not compatible with the
mainsignature, we get an error like :Websocket/Bin/Client.php
Line 79 in f5cf84e
This is related to RFC: hoaproject/Central#75.