Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade split2@4 #22

Merged
merged 1 commit into from Dec 19, 2021
Merged

Upgrade split2@4 #22

merged 1 commit into from Dec 19, 2021

Conversation

perrin4869
Copy link
Contributor

split2@3 depends on readable-stream, which is notorious for being difficult to bundle with rollup due to a circular dependency. Version 4 does away with this dependency and uses the core node stream library instead (and bumps the minimum node version to v12).
I hope this simplifies bundling node-postgres with rollup

@hoegaarden hoegaarden merged commit 114075b into hoegaarden:master Dec 19, 2021
@hoegaarden
Copy link
Owner

Thanks, @perrin4869 !

Your PR has been merged and the new version of pgpass has been published.

@perrin4869
Copy link
Contributor Author

perrin4869 commented Dec 19, 2021

Thanks @hoegaarden!
Node 10 still works, but it isn't formally supported by split2 V4... So I was wondering if it would be safer to publish this as a major release instead, dropping node 10 and adding 16 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants