This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Transactional api integration #2076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 21, 2020 12:40
added 15 commits
January 21, 2020 14:52
neonphog
suggested changes
Jan 27, 2020
neonphog
reviewed
Jan 27, 2020
crates/core/src/agent/chain_store.rs
Outdated
| use holochain_persistence_api::{ | ||
| error::PersistenceResult, | ||
| txn::{CursorDyn, CursorProviderDyn}, | ||
| }; |
There was a problem hiding this comment.
prefer uses at top of file or within a scope
neonphog
reviewed
Jan 27, 2020
| self.holding_map == other.holding_map | ||
| && (*content.read().unwrap()).get_id() == (*other_content.read().unwrap()).get_id() | ||
| && *meta.read().unwrap() == *other_meta.read().unwrap() | ||
| && (*self.persistence_manager).get_id() == (*other.persistence_manager).get_id() |
There was a problem hiding this comment.
I saw another Eq operation like this with the derefs / get_id() thing - should this be a PartialEq/Eq on the persistence_manager itself?
There was a problem hiding this comment.
Agreed that this could be a partialEQ on the Persistence Manager itself
neonphog
reviewed
Jan 27, 2020
crates/core/src/dht/dht_store.rs
Outdated
| @@ -117,28 +106,31 @@ pub fn create_get_links_eavi_query<'a>( | |||
| )) | |||
| } | |||
|
|
|||
| use holochain_persistence_api::txn::{CursorDyn, CursorProviderDyn}; | |||
neonphog
reviewed
Jan 27, 2020
| do | ||
| cd $d | ||
| if grep "$CRATE" Cargo.toml > /dev/null; then | ||
| cargo-add add $CRATE --git $REPO --branch $BRANCH |
neonphog
reviewed
Jan 27, 2020
struktured
changed the title
lucksus
approved these changes
Feb 4, 2020
added 9 commits
February 12, 2020 13:42
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR integrates the latest api changes/improvements from this holochain- persistence PR. The PR needs to be merged and release on crates.io BEFORE this PR is merged. Summary of changes:
PersistenceManagertrait which wraps a single CAS, EAV, and transactional cursor api.CursorRwto mutate the CAS and EAV in a transactional capacity in the persister and reducers.Attributeimplementation as it's provided by persistence api now.testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation